clarify logComplete msgs and return err if wait for bootstrap complete exceeds timeout #727
Conversation
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sallyom
force-pushed
the
clarify-install-complete-msg
branch
2 times, most recently
from
36c8487 to
bdc829e
Compare
cmd/openshift-install/create.go
Outdated
There was a problem hiding this comment.
sounds good to me. I'll remove this from this PR, keep the log msg edits in.
cmd/openshift-install/create.go
Outdated
There was a problem hiding this comment.
Is this the recommended approach? It seems like oc get nodes -w might be more efficient (no polling). But it wouldn't be worker-specific. Maybe you could address that with --selector? Or maybe there are likely to be few enough masters (compared to workers) in most (all?) clusters that you don't need to bother filtering the masters out here?
There was a problem hiding this comment.
I was going to ask (you) what the most efficient way was :) but do you agree that suggesting that one wait for workers to be created is appropriate?
…e exceeds timeout
sallyom
force-pushed
the
clarify-install-complete-msg
branch
from
bdc829e to
f62e75f
Compare
openshift-ci-robot
added
size/XS
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
IMO the installer can bring up a cluster with zero workers. So not sure this is going to be always correct. |
|
@abhinavdahiya yes, you're right there. I'm closing this, the real reason this was opened was to error out instead of complete successfully if the bootstrap process exceeded the timeout. @wking suggested that reverting #615 is a better approach. closing... although the wording of |
4 participants
@crawford
This PR
adds an error return if bootstrap process exceeds the timeout (rather than returning nil)@droslean noticed the successful logComplete msg was shown after an install exited due to timeout exceeded, since that error was not being returned. Any reason it should not return the error there?
EDIT: @wking suggested
revert #615 now that we're comfortable with the robustness of #606below.